PMD Results

The following document contains the results of PMD 5.6.1.

Files

org/devzendo/xplp/CreateLauncherMojo.java

Violation Line
Too many fields 45416
The class 'CreateLauncherMojo' has a Cyclomatic Complexity of 5 (Highest = 11). 45416
Avoid excessively long variable names like remoteRepositories 59
Avoid excessively long variable names like artifactMetadataSource 61
Avoid variables with short names like os 71
Avoid excessively long variable names like narClassifierTypes 148
The method 'execute' has a Cyclomatic Complexity of 11. 243307
Potential violation of Law of Demeter (method chain calls) 244
Avoid excessively long variable names like transitiveArtifacts 252
Avoid excessively long variable names like resourceDirectories 253
Avoid excessively long variable names like parameterProperties 254
Potential violation of Law of Demeter (method chain calls) 255
Potential violation of Law of Demeter (method chain calls) 256
Potential violation of Law of Demeter (method chain calls) 257
Potential violation of Law of Demeter (method chain calls) 258
Potential violation of Law of Demeter (method chain calls) 259
Potential violation of Law of Demeter (method chain calls) 260
Potential violation of Law of Demeter (method chain calls) 261
Potential violation of Law of Demeter (method chain calls) 262
Position literals first in String comparisons 265
Position literals first in String comparisons 266
Position literals first in String comparisons 282
Potential violation of Law of Demeter (method chain calls) 283
Position literals first in String comparisons 289
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 300
Potential violation of Law of Demeter (method chain calls) 303
New exception is thrown in catch block, original stack trace may be lost 305
Potential violation of Law of Demeter (method chain calls) 317
Consider using varargs for methods or constructors which take an array the last parameter. 326
Avoid variables with short names like sb 327
Avoid variables with short names like in 361
Avoid instantiating new objects inside loops 371
Potential violation of Law of Demeter (method chain calls) 381
Potential violation of Law of Demeter (method chain calls) 393395
Potential violation of Law of Demeter (method chain calls) 397
Potential violation of Law of Demeter (method chain calls) 398
Potential violation of Law of Demeter (method chain calls) 398
Potential violation of Law of Demeter (method chain calls) 398
Potential violation of Law of Demeter (method chain calls) 400
Potential violation of Law of Demeter (method chain calls) 404
New exception is thrown in catch block, original stack trace may be lost 405
Potential violation of Law of Demeter (method chain calls) 408
New exception is thrown in catch block, original stack trace may be lost 409
Potential violation of Law of Demeter (method chain calls) 412
New exception is thrown in catch block, original stack trace may be lost 413

org/devzendo/xplp/LauncherCreator.java

Violation Line
Possible God class (WMC=66, ATFD=37, TCC=0.0049261083743842365) 20525
Abstract classes should be named AbstractXXX 51525
This class has too many methods, consider refactoring it. 51525
Avoid excessively long variable names like mTransitiveArtifacts 57
Avoid excessively long variable names like mResourceDirectories 58
Avoid excessively long variable names like mParameterProperties 59
Avoid excessively long variable names like mNarClassifierTypes 62
Avoid long parameter lists. 7787
Avoid excessively long variable names like transitiveArtifacts 82
Avoid excessively long variable names like resourceDirectories 83
Avoid excessively long variable names like parameterProperties 84
Avoid excessively long variable names like narClassifierTypes 87
Consider using varargs for methods or constructors which take an array the last parameter. 87
Potential violation of Law of Demeter (method chain calls) 187
Potential violation of Law of Demeter (method chain calls) 194
The String literal "Created " appears 4 times in this file; the first occurrence is on line 194 194
Potential violation of Law of Demeter (method chain calls) 208
Potential violation of Law of Demeter (method chain calls) 216
New exception is thrown in catch block, original stack trace may be lost 217
Avoid instantiating new objects inside loops 224
Potential violation of Law of Demeter (method chain calls) 225
Potential violation of Law of Demeter (method chain calls) 228
Potential violation of Law of Demeter (method chain calls) 232
Potential violation of Law of Demeter (method chain calls) 237
Potential violation of Law of Demeter (method chain calls) 237
Consider simply returning the value vs storing it in local variable 'resourceAsStream' 238
Avoid excessively long variable names like transitiveArtifacts 248
Avoid excessively long variable names like transitiveArtifact 250
Potential violation of Law of Demeter (method chain calls) 251
Potential violation of Law of Demeter (method chain calls) 252
Potential violation of Law of Demeter (method chain calls) 253
Potential violation of Law of Demeter (method chain calls) 254
Potential violation of Law of Demeter (method chain calls) 254
Avoid excessively long variable names like destinationDirectory 268
Avoid excessively long variable names like destinationFileName 269
Avoid excessively long variable names like destinationDirectory 276
Avoid excessively long variable names like destinationFileName 277
Potential violation of Law of Demeter (method chain calls) 283
New exception is thrown in catch block, original stack trace may be lost 284
Potential violation of Law of Demeter (method chain calls) 292
New exception is thrown in catch block, original stack trace may be lost 293
Potential violation of Law of Demeter (method chain calls) 297301
Potential violation of Law of Demeter (method chain calls) 320
New exception is thrown in catch block, original stack trace may be lost 321
Avoid excessively long variable names like destinationDirectory 341
Potential violation of Law of Demeter (method chain calls) 342
Potential violation of Law of Demeter (method chain calls) 342
Avoid excessively long variable names like transitiveArtifacts 343
Potential violation of Law of Demeter (method chain calls) 344
Potential violation of Law of Demeter (object not created locally) 344
Potential violation of Law of Demeter (method chain calls) 344
Potential violation of Law of Demeter (method chain calls) 346
Potential violation of Law of Demeter (method chain calls) 349
Potential violation of Law of Demeter (method chain calls) 349
Avoid excessively long variable names like destinationDirectory 355
Potential violation of Law of Demeter (method chain calls) 357
Potential violation of Law of Demeter (method chain calls) 357
Potential violation of Law of Demeter (method chain calls) 358
Potential violation of Law of Demeter (method chain calls) 358
Potential violation of Law of Demeter (method chain calls) 362
Potential violation of Law of Demeter (method chain calls) 362
Potential violation of Law of Demeter (object not created locally) 364
Potential violation of Law of Demeter (object not created locally) 364
Potential violation of Law of Demeter (method chain calls) 365
Potential violation of Law of Demeter (method chain calls) 371
Potential violation of Law of Demeter (method chain calls) 371
Potential violation of Law of Demeter (method chain calls) 372
Potential violation of Law of Demeter (method chain calls) 372
Potential violation of Law of Demeter (method chain calls) 373
Potential violation of Law of Demeter (method chain calls) 373
Avoid excessively long variable names like destinationDirectory 378
Potential violation of Law of Demeter (object not created locally) 380
Potential violation of Law of Demeter (method chain calls) 380
Avoid excessively long variable names like destinationJarFileName 380
Potential violation of Law of Demeter (method chain calls) 385
Potential violation of Law of Demeter (method chain calls) 385
Avoid excessively long variable names like destinationDirectory 391
Potential violation of Law of Demeter (method chain calls) 394
Potential violation of Law of Demeter (method chain calls) 394
Avoid excessively long variable names like unpackedNarDirectory 395
Potential violation of Law of Demeter (method chain calls) 397399
Potential violation of Law of Demeter (method chain calls) 397399
Potential violation of Law of Demeter (method chain calls) 400
Potential violation of Law of Demeter (method chain calls) 400
Potential violation of Law of Demeter (method chain calls) 406
Potential violation of Law of Demeter (method chain calls) 406
Position literals first in String comparisons 409
Potential violation of Law of Demeter (object not created locally) 409
Potential violation of Law of Demeter (method chain calls) 410
Potential violation of Law of Demeter (method chain calls) 410
Potential violation of Law of Demeter (object not created locally) 413
Potential violation of Law of Demeter (object not created locally) 413
Potential violation of Law of Demeter (method chain calls) 415
Potential violation of Law of Demeter (method chain calls) 415
Avoid variables with short names like br 429
Avoid variables with short names like br 440
Avoid variables with short names like br 447
Avoid variables with short names like fw 452
Potential violation of Law of Demeter (object not created locally) 461
Potential violation of Law of Demeter (object not created locally) 462
Potential violation of Law of Demeter (object not created locally) 463
Potential violation of Law of Demeter (object not created locally) 464
Potential violation of Law of Demeter (object not created locally) 465
Potential violation of Law of Demeter (method chain calls) 469
Potential violation of Law of Demeter (method chain calls) 469
New exception is thrown in catch block, original stack trace may be lost 470
Potential violation of Law of Demeter (object not created locally) 475
Avoid using exceptions as flow control. 476
Avoid using exceptions as flow control. 476
Avoid using exceptions as flow control. 483
Potential violation of Law of Demeter (method chain calls) 487489
Potential violation of Law of Demeter (method chain calls) 487489
Potential violation of Law of Demeter (method chain calls) 499
New exception is thrown in catch block, original stack trace may be lost 500
Potential violation of Law of Demeter (method chain calls) 509
Potential violation of Law of Demeter (method chain calls) 509
Avoid variables with short names like cl 510
Potential violation of Law of Demeter (method chain calls) 517
Potential violation of Law of Demeter (method chain calls) 517
Potential violation of Law of Demeter (method chain calls) 518
Potential violation of Law of Demeter (method chain calls) 518
Potential violation of Law of Demeter (method chain calls) 519
Potential violation of Law of Demeter (method chain calls) 519
Potential violation of Law of Demeter (method chain calls) 522
Potential violation of Law of Demeter (method chain calls) 522

org/devzendo/xplp/LinuxLauncherCreator.java

Violation Line
Avoid long parameter lists. 4858
Avoid excessively long variable names like transitiveArtifacts 53
Avoid excessively long variable names like resourceDirectories 54
Avoid excessively long variable names like parameterProperties 55
Avoid excessively long variable names like narClassifierTypes 58
Consider using varargs for methods or constructors which take an array the last parameter. 58

org/devzendo/xplp/MacOSXAppLauncherCreator.java

Violation Line
Avoid long parameter lists. 7289
Avoid excessively long variable names like transitiveArtifacts 77
Avoid excessively long variable names like resourceDirectories 78
Avoid excessively long variable names like parameterProperties 79
Avoid excessively long variable names like narClassifierTypes 82
Potential violation of Law of Demeter (method chain calls) 107
Potential violation of Law of Demeter (method chain calls) 107
Potential violation of Law of Demeter (method chain calls) 112
Potential violation of Law of Demeter (method chain calls) 112
Potential violation of Law of Demeter (method chain calls) 117
Potential violation of Law of Demeter (method chain calls) 117
Potential violation of Law of Demeter (method chain calls) 128
Potential violation of Law of Demeter (method chain calls) 129
Potential violation of Law of Demeter (method chain calls) 130
Potential violation of Law of Demeter (method chain calls) 132
Potential violation of Law of Demeter (method chain calls) 132
Potential violation of Law of Demeter (method chain calls) 133
Potential violation of Law of Demeter (method chain calls) 133
Potential violation of Law of Demeter (method chain calls) 134
Potential violation of Law of Demeter (method chain calls) 134
Potential violation of Law of Demeter (method chain calls) 135
Potential violation of Law of Demeter (method chain calls) 135
Potential violation of Law of Demeter (method chain calls) 136
Potential violation of Law of Demeter (method chain calls) 136
Potential violation of Law of Demeter (method chain calls) 137
Potential violation of Law of Demeter (method chain calls) 137
Potential violation of Law of Demeter (method chain calls) 138
Potential violation of Law of Demeter (method chain calls) 138
Avoid excessively long variable names like javaApplicationStub 160
Consider using varargs for methods or constructors which take an array the last parameter. 177
Consider using varargs for methods or constructors which take an array the last parameter. 196
Avoid excessively long variable names like propsAsDictEntries 197
Avoid excessively long variable names like propsAsDictEntries 207
Avoid excessively long variable names like transitiveArtifacts 219
StringBuffer constructor is initialized with size 16, but has at least 43 characters appended. 220
Avoid excessively long variable names like transitiveArtifactFileNames 221

org/devzendo/xplp/MacOSXScriptLauncherCreator.java

Violation Line
Avoid long parameter lists. 5162
Avoid excessively long variable names like transitiveArtifacts 56
Avoid excessively long variable names like resourceDirectories 57
Avoid excessively long variable names like parameterProperties 58
Avoid excessively long variable names like narClassifierTypes 61
Potential violation of Law of Demeter (method chain calls) 75
Potential violation of Law of Demeter (method chain calls) 75

org/devzendo/xplp/PropertiesInterpolator.java

Violation Line
Avoid excessively long variable names like variableReferenceMatcher 35
Avoid variables with short names like s 61

org/devzendo/xplp/UnixScriptLauncherCreator.java

Violation Line
Avoid excessively long variable names like mOsOutputSubDirectoryName 40
Avoid long parameter lists. 5869
Avoid excessively long variable names like osOutputSubDirectoryName 60
Avoid excessively long variable names like transitiveArtifacts 64
Avoid excessively long variable names like resourceDirectories 65
Avoid excessively long variable names like parameterProperties 66
Consider using varargs for methods or constructors which take an array the last parameter. 69
Avoid excessively long variable names like narClassifierTypes 69
Potential violation of Law of Demeter (method chain calls) 91
Potential violation of Law of Demeter (method chain calls) 102
Potential violation of Law of Demeter (method chain calls) 103
Consider using varargs for methods or constructors which take an array the last parameter. 112
Consider using varargs for methods or constructors which take an array the last parameter. 116
Avoid excessively long variable names like transitiveArtifacts 124
Avoid excessively long variable names like transitiveArtifactFileNames 126

org/devzendo/xplp/WindowsLauncherCreator.java

Violation Line
Avoid long parameter lists. 5668
Avoid excessively long variable names like transitiveArtifacts 61
Avoid excessively long variable names like resourceDirectories 62
Avoid excessively long variable names like parameterProperties 63
Avoid excessively long variable names like narClassifierTypes 66
Consider using varargs for methods or constructors which take an array the last parameter. 68
Potential violation of Law of Demeter (method chain calls) 81
Potential violation of Law of Demeter (method chain calls) 81
Position literals first in String comparisons 84
Position literals first in String comparisons 84
Potential violation of Law of Demeter (method chain calls) 86
Potential violation of Law of Demeter (method chain calls) 86
Potential violation of Law of Demeter (method chain calls) 97
Potential violation of Law of Demeter (method chain calls) 98
Potential violation of Law of Demeter (method chain calls) 99
Potential violation of Law of Demeter (method chain calls) 101
Potential violation of Law of Demeter (method chain calls) 101
Potential violation of Law of Demeter (method chain calls) 109
Position literals first in String comparisons 113
Consider using varargs for methods or constructors which take an array the last parameter. 123
Consider using varargs for methods or constructors which take an array the last parameter. 134